From: Joe Ratterman <jratt0@gmail.com>
Date: Tue, 29 Mar 2011 03:12:27 GMT
Subject: Re: [PATCH] grep: allow -E and -n to be turned on by default via configuration
Message-ID: <AANLkTikpjoyPWYomKsi0YA=KrcPU2Qxn0dBgjbUi2B_x@mail.gmail.com>
In-Reply-To: <7vbp0ux5c9.fsf_-_@alter.siamese.dyndns.org>

On Mon, Mar 28, 2011 at 5:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
>   I did not add tests, but we do need one perhaps at the end of t7810 to
>   move things forward.


What sort of tests would be appropriate?  I cannot find anything that
tests -E/--extended-regexp.  I copied the first test that used "git
grep -n" and changed it to these:
1)  git -c grep.linenumber=false grep -n  #  Expected to have line numbers
2)  git -c grep.linenumber=true grep  #  Expected to have line numbers
3)  git -c grep.linenumber=true grep --no-line-number  #  Expected to
have no line numbers


Joe