From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Mon, 25 Oct 2010 10:30:33 GMT
Subject: Re: [WIP PATCH 01/18] rev-parse: add --internal-cwd and --internal-git-dir for tests
Message-ID: <AANLkTikm+JxyXk_bVXKaX_0aaSfqjrXU=m946Nm0=1vV@mail.gmail.com>
In-Reply-To: <m339ruk284.fsf@localhost.localdomain>

On Mon, Oct 25, 2010 at 5:15 PM, Jakub Narebski <jnareb@gmail.com> wrote:
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> 2010/10/24 Jonathan Nieder <jrnieder@gmail.com>:
>
>> > I think it might: just like the exec: lines provide context about what
>> > command is being traced, such trace: cwd: lines would make it clearer
>> > what paths that are being output might be referring to.
>>
>> Also prefix them all with "setup:", something like
>>
>> setup: git_dir: ../.git
>> setup: work_tree: /my/git/worktree
>> setup: cwd: /my/git/worktree
>> setup: prefix: sub/
>
> I guess that those paths would be c-quoted, if necessary (trailing
> space, embedded newline, quotes, etc.)?

For the sake of grep (because '\n' may break lines), yes.
-- 
Duy