From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 17 Sep 2010 06:54:03 GMT
Subject: Re: [PATCH 5/7] gitweb: auxiliary functions to group data
Message-ID: <AANLkTikk7vUFMr31Azdcpe+PK0-yA2sp2EcnHjdfw0Zn@mail.gmail.com>
In-Reply-To: <201009170324.25801.jnareb@gmail.com>

On Fri, Sep 17, 2010 at 3:24 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> ... but I think that having separate subroutines for opening and
> closing tags is a bad design / bad API (except in some rare cases).
> It is begging for unbalanced HTML.
>
> It would be better if it was a single subroutine wrapping 'div' around
> contents given either as a string, or via callback (subroutine reference),
> in my opinion.

I'm not sure that in this case the string or callback approach would
be any cleaner. I'll see if perl supports closures or something like
that.

-- 
Giuseppe "Oblomov" Bilotta