From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Wed, 15 Dec 2010 01:58:11 GMT
Subject: Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax
Message-ID: <AANLkTikgXAg9+0TXzpFH7LT1yD2sV5Dp=025GbudnY5S@mail.gmail.com>
In-Reply-To: <7vaak7rh9k.fsf@alter.siamese.dyndns.org>

2010/12/15 Junio C Hamano <gitster@pobox.com>:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> +test_expect_success 'ref^{/}' '
>> +     git rev-parse master >expected &&
>> +     git rev-parse master^{/} >actual &&
>> +     test_cmp expected actual
>> +'
>
> This test fails on FBSD 8, which refuses to regcomp("")
> saying "empty (sub)expression", which is somewhat bogus.
>
> I'd change it to "/." for now ;-).

Perhaps we should just reject this case. No sane body would ever use it.
-- 
Duy