From: Thomas Berg Date: Fri, 28 Jan 2011 15:19:33 GMT Subject: Re: [PATCH] git-p4: Corrected typo. Message-ID: In-Reply-To: Hi, On Fri, Jan 28, 2011 at 12:35 AM, Vitor Antunes wrote: > Hi everyone, > > Could anyone comment the 3 patches I sent (being this the last one)? > [...] > On Thu, Nov 25, 2010 at 1:26 AM, Vitor Antunes wrote: >> --- >>  contrib/fast-import/git-p4 |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 >> index 0ea3a44..a466847 100755 >> --- a/contrib/fast-import/git-p4 >> +++ b/contrib/fast-import/git-p4 >> @@ -618,7 +618,7 @@ class P4Submit(Command): >>         if len(detectRenames) > 0: >>             diffOpts = "-M%s" % detectRenames >>         else: >> -            diffOpts = ("", "-M")[self.detectRenames] >> +            diffOpts = ("", "-M")[self.detectRename] >> This appears to me to be a bugfix for one of the other patches you sent, is that right? If so, maybe you could squash it with the previous patch and re-send it all to the list? My other comments for now are: - you have forgotten to sign off on the patches - commit messages are normally in imperative rather than past tense (see Documentation/SubmittingPatches in git) - In your first patch you wrote: > The detectRenames option should be set to the desired threshold value. I'm not sure what threshold value you refer to here, and what values you can set it to. Am I missing something? (I'm not very familiar with git rename detection options) I'm a git-p4 user, so I can test your changes and look a bit more at your code. Someone verifying it could help getting the patches applied. Thanks for improving git-p4! Cheers, Thomas Berg