From: Diane Gasselin <diane.gasselin@ensimag.imag.fr>
Date: Mon, 14 Jun 2010 07:52:48 GMT
Subject: Re: [PATCH v2 3/3] t/t8006: test textconv support for blame
Message-ID: <AANLkTikZCtymKUgD3uYj7kU3HDuo2Y-oJr2f10CKRbgU@mail.gmail.com>
In-Reply-To: <7vd3vxgm9x.fsf@alter.siamese.dyndns.org>

Le 12 juin 2010 01:52, Junio C Hamano <gitster@pobox.com> a écrit :
> Axel Bonnet <axel.bonnet@ensimag.imag.fr> writes:
>
>> Test the correct functionning of textconv with blame <file> and blame HEAD^ <file>.
>> Test the case when no driver is specified.
>
> Good to see tests for both positive and negative cases.  Too many people
> forget the latter.
>
>> +find_blame() {
>> +     sed -e 's/^.*(/(/g'
>> +}
>
> Two issues:
>
>  - No need for "g" as your pattern is anchored at the left;
>
>  - As ".*" is greedy, you will eat a lot more than what you expect when
>   the line in the blamed contents happen to have '(' on it.
>
> I'd rewrite it as:
>
>    sed -e 's/^[^(]*//'
>
> Will queue all three patches, with this fix and a style fix for 2/3; no
> need to resend.
>
> Thanks.
>
Thanks. And thanks for fixing.