From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 19 Aug 2010 00:24:54 GMT
Subject: Re: [RFC/PATCH] Add test case for dealing with a tracked file in an ignored directory
Message-ID: <AANLkTikLUQCnrDAp8c0QBWoGE1XUgXmd8g_19v3HnxJ4@mail.gmail.com>
In-Reply-To: <20100819000052.GA11081@burratino>

On Thu, Aug 19, 2010 at 00:00, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Matthieu Moy wrote:
>
>> Not sure what is the gain by doing so, and the vast majority of tests
>> already there use the style of Greg's patch ...
>
> Right.  The usual rule when contributing to an existing project is
> "imitate the surruounding code", but there is often a tension between
> global style guidelines and the local conventions.
>
> In this case I have to agree with Matthieu: the test script is
> easier to read if it follows a single, consistent style.  The cleanup
> can happen another day.

Sure, I don't feel in any way strongly about it. I just try to
(hopefully mostly helpfully) to point out common things that
contradict the docs we have, especially with the tests, since I'm
getting pretty familiar with them :)