From: Erik Faye-Lund Date: Mon, 07 Feb 2011 19:22:49 GMT Subject: Re: [PATCH/RFC] commit: fix memory-leak Message-ID: In-Reply-To: On Mon, Feb 7, 2011 at 7:48 PM, Matthieu Moy wrote: > Erik Faye-Lund writes: > >> At the same time, this fixes a problem with strict-POSIX getenv >> implementations. POSIX says "The return value from getenv() may >> point to static data which may be overwritten by subsequent calls >> to getenv()", so duplicating the strings is a potential bug. >                  ^ >                 not > ? Indeed, thanks.