From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 10 Sep 2010 22:53:50 GMT
Subject: Re: [PATCH 3/5] gettext docs: the gettext.h C interface
Message-ID: <AANLkTikHvr7Xp8jST4wrtyhF3UY5hnvVsuEsr=D9byXj@mail.gmail.com>
In-Reply-To: <7viq2dgrji.fsf@alter.siamese.dyndns.org>

On Fri, Sep 10, 2010 at 22:30, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> +C:
>> +
>> + - Include builtin.h at the top, it'll pull in in gettext.h, which
>> +   defines the gettext interface.
>
> Hmm, I would have thought that <git-compat-util.h> would be a much more
> natural place for this kind of thing, not <builtin.h>.  Shouldn't you be
> able to write a non-builtin Porcelain if you wanted to?

I don't know, I just put it in builtin.h for the builtin/*.c commands,
the rest of the porcelain stuff should all have gettext.h already.

Maybe gettext.h should be in git-compat-util.h, I don't know.