From: Sverre Rabbelier Date: Tue, 27 Jul 2010 06:43:22 GMT Subject: Re: [RFC PATCH 1/2] Allow "git log --grep foo" as synonym for "git log --grep=foo". Message-ID: In-Reply-To: <1280168078-31147-2-git-send-email-Matthieu.Moy@imag.fr> Heya, On Mon, Jul 26, 2010 at 13:14, Matthieu Moy wrote: > +       } else if (!strcmp(arg, "--grep")) { > +               add_message_grep(revs, optarg); > +               return 2; This one makes a little less sense since to me '--flag' are always booleans, whereas '-m' can take an argument (such as '-m' from 'git commit'. -- Cheers, Sverre Rabbelier