From: Jeffrey Middleton <jefromi@gmail.com>
Date: Fri, 19 Nov 2010 17:16:53 GMT
Subject: Re: pager config for external commands
Message-ID: <AANLkTikE6=At-BV22myZtM4nuNL6z4hoJ-kS=O1LkBXo@mail.gmail.com>
In-Reply-To: <20101119160058.GA7967@sigill.intra.peff.net>

On Fri, Nov 19, 2010 at 10:00 AM, Jeff King <peff@peff.net> wrote:
> Basically the problem is that we just call execv("git-<cmd>"). If it
> works, then we are running an external, but we no longer have an
> opportunity to start the pager. If it doesn't, then we don't necessarily
> want to commit our pager choice. We may be running an alias, or we may
> simply barf with "no such command".

Okay, that makes sense, I think. But execv_dashed_external does
currently commit the pager choice, just without looking it up from the
config. This means that, for example, git --paginate
<nonexistent-command> does invoke the pager. Is that intended? I don't
think I see any tests covering the combination of pager.<cmd> for
anything but builtins.

Also, instead of having git implement "look up in PATH" internally,
would it make sense to simply commit the pager choice, try the execv,
then uncommit the pager choice if the command was not found?

Jeffrey