From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 24 Sep 2010 23:04:22 GMT
Subject: Re: [RFC PATCHv2 12/16] t6050 (replace): add missing &&
Message-ID: <AANLkTikDbuMh9fRhyMDjq=ysUkiCuku=dfKTqnJ_7M7=@mail.gmail.com>
In-Reply-To: <1285366976-22216-13-git-send-email-newren@gmail.com>

On Fri, Sep 24, 2010 at 22:22, Elijah Newren <newren@gmail.com> wrote:
> FIXME: Is the grep really meant to fail?

It should be "! grep" not "test_must_fail grep". test_must_fail is for
git, not posix commands. If grep starts segfaulting we're screwed
anyway.

And this should use files and test_cmp or grep them if possible, not
use pipes. It's hard to debug these when they fail.