From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Mon, 28 Feb 2011 21:36:33 GMT
Subject: Re: [PATCH svn-fe] fast-import: make code "-Wpointer-arith" clean
Message-ID: <AANLkTikD8qQKdhXN9dx+hk8r=eGRBtc3eRSFU2vDxmsP@mail.gmail.com>
In-Reply-To: <20110228213210.GD1942@elie>

Heya,

On Mon, Feb 28, 2011 at 22:32, Jonathan Nieder <jrnieder@gmail.com> wrote:
> This should fix it, I suppose?  A
>
>        -std=c99 -O3 -Wall -W
>        -Wno-sign-compare
>        -Wno-unused-parameter
>        -Wno-missing-field-initializers
>        -Wno-empty-body
>        -Wno-pointer-to-int-cast
>        -Wno-type-limits
>        -Wno-unused-but-set-variable
>        -Wold-style-definition -Wpointer-arith -Wvla
>        -Wdeclaration-after-statement -Werror
>
> build passes, except for an "unsigned long expire" in builtin-reflog
> that confuses this copy of gcc.

How come this slipped by unnoticed (except by Junio)? Is the default
Makefile not strict enough?

-- 
Cheers,

Sverre Rabbelier