From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 24 Jul 2010 23:29:20 GMT
Subject: Re: [PATCH 3/6] Makefile: Split out the untested functions target
Message-ID: <AANLkTikB_QV6NoaNkubfM267tZvjYN7LzMNTFkwW-eEO@mail.gmail.com>
In-Reply-To: <201007250102.20099.trast@student.ethz.ch>

On Sat, Jul 24, 2010 at 23:02, Thomas Rast <trast@student.ethz.ch> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> Change the coverage-report target so that it doesn't generate the
>> coverage-untested-functions file by default. I'm adding more targets
>> for doing various things with the gcov files, and they shouldn't all
>> run by default.
>>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> ---
>>  Makefile |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 63f3f84..5e9a6a2 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2299,6 +2299,8 @@ coverage-report:
>>       gcov -b -o builtin builtin/*.c
>>       gcov -b -o xdiff xdiff/*.c
>>       gcov -b -o compat compat/*.c
>> +
>> +coverage-report-untested-functions:
>>       grep '^function.*called 0 ' *.c.gcov \
>>               | sed -e 's/\([^:]*\)\.gcov: *function \([^ ]*\) called.*/\1: \2/' \
>>               | tee coverage-untested-functions
>
> This should depend on coverage-report, and either have its name
> changed to coverage-untested-functions or be .PHONY.

Will fix, thanks.