From: Sverre Rabbelier Date: Thu, 04 Nov 2010 10:44:46 GMT Subject: Re: [PATCH 2/2] rebase: teach --autosquash to match on sha1 in addition to message Message-ID: In-Reply-To: <5CCA000B-2178-4DF7-8D72-29F95A9BB360@sb.org> Heya, On Thu, Nov 4, 2010 at 05:49, Kevin Ballard wrote: > I just realized that this only works for sha1's of up to 7 characters. > If you provide more it won't match, as it's comparing against the sha1 > given in the todo list. I wonder if it's worth resolving all sha1s to > their full length if the provided string is longer than 7 characters? Well, not if you're resolving them based on the 7-character string from the rebase todo list. If you run in to ambiguity with those 7-length hash we should instead increase the length of the hashes in the todo list. So I'd say, solve this by doing a prefix match? -- Cheers, Sverre Rabbelier