From: Steven Walter <stevenrwalter@gmail.com>
Date: Fri, 03 Sep 2010 19:26:09 GMT
Subject: Re: [PATCH] Add unit test for check_cherry_pick
Message-ID: <AANLkTik5kcD1reuGfq4k_Oidkx00MY8E+Ucf+Ef_gCDD@mail.gmail.com>
In-Reply-To: <AANLkTikjGgzOxNz-Fepcg2ALqdWurzMyQUmRgqyxQN5L@mail.gmail.com>

On Fri, Sep 3, 2010 at 3:12 PM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Fri, Sep 3, 2010 at 18:52, Steven Walter <stevenrwalter@gmail.com> wrote:
>
>> +GIT_SVN_LC_ALL=${LC_ALL:-$LANG}
>
> What's this about?
>
>> +. ./lib-git-svn.sh
>> +
>> +say 'define NO_SVN_TESTS to skip git svn tests'
>> +
>> +case "$GIT_SVN_LC_ALL" in
>> +*.UTF-8)
>> +       test_set_prereq UTF8
>
> You never use this prereq?

I'll admit that I copied these from t9100.  I assumed they were
necessary for correct operation.  If that's not the case, then they
can be removed.
-- 
-Steven Walter <stevenrwalter@gmail.com>