From: Øyvind A. Holm <sunny@sunbase.org>
Date: Tue, 29 Mar 2011 13:37:10 GMT
Subject: Re: 195b7ca6 breaks t9010 at current master
Message-ID: <AANLkTi=pDM2AXwLWtQQmp77dAzhooFSMXHtKAoN_S8_a@mail.gmail.com>
In-Reply-To: <20110329042446.GB25693@elie>

On 29 March 2011 06:24, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Øyvind A. Holm wrote:
> > When running "make test" at current master (v1.7.4.2-406-gbe919d5),
> > t9010-svn-fe.sh fails. Bisecting shows that 195b7ca6 ("vcs-svn:
> > handle log message with embedded NUL") breaks the test.
>
> Could you try with the following patch applied?  It comes from
> squashing the last two patches from the svn-fe branch:
>
> * tests: make sure input to sed is newline terminated
> * vcs-svn: add missing cast to printf argument

Thanks a lot. Yes, that works. It seems as it's "vcs-svn: add missing
cast to printf argument" that does the trick, at least t9010 doesn't
fail after that's applied. ... And it has reached the official master
now (as 8cc299d), seems it got pushed after I went to bed. I'm running a
test on current master (07514c8) now, and things look fine so far.

Regards,
Øyvind