From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 09 Sep 2010 16:59:02 GMT
Subject: Re: [PATCH v2] po/hi.po: Add Hindi Translation
Message-ID: <AANLkTi=e=b_u=5NFhZLyUeUNaio6okt=+8nM0dv3G49x@mail.gmail.com>
In-Reply-To: <20100909153350.GB27725@kytes>

On Thu, Sep 9, 2010 at 15:33, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

> Couple of silly mistakes that were breaking the build spotted by
> Ævar. Here's the diff.
> --- a/po/hi.po
> +++ b/po/hi.po
> @@ -2,6 +2,7 @@ msgid ""
>  msgstr ""
>  "Project-Id-Version: Git\n"
>  "Report-Msgid-Bugs-To: Git Mailing List <git@vger.kernel.org>\n"
> +"PO-Revision-Date: 2010-09-09 20:55+0530\n"
>  "Language-Team: Git Mailing List <git@vger.kernel.org>\n"
>  "Last-Translator: Ramkumar Ramachandra <artagnon@gmail.com>\n"
>  "POT-Creation-Date: 2010-09-05 16:05+0530\n"
> @@ -60,7 +61,7 @@ msgstr "टेम्पलेट्स नहीं मिले: %s"
>
>  #, c-format
>  msgid "not copying templates of a wrong format version %d from '%s'"
> -msgstr "'%s' से गलत स्वरूप संस्करण %d के टेम्पलेट्स की नकल नहीं कर रहे हैं"
> +msgstr "'%2$s' से गलत स्वरूप संस्करण %1$d के टेम्पलेट्स की नकल नहीं कर रहे हैं"

Both look good to me, thanks.

In the future I'll add a bit to po/README about how you need to run
msgfmt --check (or just make at the top-level) when submitting *.po
files.

We might also want to drop --check and use --check-format (i.e. not
--check-header) and maybe --check-domain too. But that's something to
fix another day.

Acked-by: Ævar Arnfjörð <avarab@gmail.com>