From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Thu, 06 Jan 2011 20:14:07 GMT
Subject: Re: [PATCH v2] alias: use run_command api to execute aliases
Message-ID: <AANLkTi=aPjtfFVKX6XqHyZYVaT07ExnWVF140JJ==U+m@mail.gmail.com>
In-Reply-To: <20110106200518.GA14945@burratino>

On Jan 6, 2011 9:05 PM, "Jonathan Nieder" <jrnieder@gmail.com> wrote:
>
> Erik Faye-Lund wrote:
>
> > --- a/git.c
> > +++ b/git.c
> > @@ -177,22 +177,22 @@ static int handle_alias(int *argcp, const char
***argv)
> [...]
> > +                     alias_argv = xmalloc(sizeof(char *) * argc + 1);
>
> Missed a spot?  (missing parens)
>

Blergh... I guess that teaches me a lesson about sending out patches in a
hurry. New version a bit later, then ;)

> Thanks for this.  It also should provide a minor speedup in the case
> of commands with no shell metacharacters.

Nice. Not intentional, but hey :)