From: Nguyen Thai Ngoc Duy Date: Thu, 26 Aug 2010 23:15:29 GMT Subject: Re: [PATCH 2/7] Fix ignoring of pathspecs with rev-list --objects Message-ID: In-Reply-To: On Thu, Aug 26, 2010 at 9:50 AM, Elijah Newren wrote: >> While at it, can you please also fix its comments? The comments say >> pathspec while what it uses is actually path prefix. Maybe something >> like this >> >> diff --git a/tree-diff.c b/tree-diff.c >> index 3c34c77..514dbca 100644 >> --- a/tree-diff.c >> +++ b/tree-diff.c >> @@ -83,7 +83,7 @@ static int compare_tree_entry(struct tree_desc *t1, >> struct tree_desc *t2, const >>  } >> >>  /* >> - * Is a tree entry interesting given the pathspec we have? >> + * Is a tree entry interesting given the path prefix we have? > > I believe the comment is parsed thus: "tree entry" == combination of > desc, base, and baselen.  "pathspec" == paths and pathlens fields of > opt (which do provide a pathspec).  So I believe the original was > correct, though I can see how it's confusing at first. Pathspec as in match_pathspec() in dir.c allows wildcards. Though it seems only used with worktree or index-related operations. To me the one with wildcard support is called pathspec. The one without is path prefix. But it's probably just me. There is also a GSoC suggestion about this [1] and I posted a related patch a while back [2] but forgot it until now. [1] https://git.wiki.kernel.org/index.php/SoC2010Ideas#Unify_Pathspec_Semantics [2] http://mid.gmane.org/1243240924-5981-1-git-send-email-pclouds@gmail.com -- Duy