From: Alex Riesen Date: Mon, 23 Aug 2010 19:02:36 GMT Subject: Re: "git -c web.browser=w3m help -w help" still kicks firefox Message-ID: In-Reply-To: <7viq3119yn.fsf@alter.siamese.dyndns.org> On Mon, Aug 23, 2010 at 20:05, Junio C Hamano wrote: > I know exactly why this happens---we save the config from the command line > on a list only so that we can apply them in the correct order after items > coming from files, but we do not use the saved values to pass them around > to sub-git invocations. > >  8b1fa77 (Allow passing of configuration parameters in the command line, 2010-03-26) > > A "trivial fix" would be to pass this info through the execv_git_cmd() > interface by either exporting it via an environment variable or by > modifying the command line options, but I am not sure about the possible > fallouts from such a change.  For example, does "git -c var=value config ..." > work sensibly when what "config" is told to do (say, remove a section) > contradicts with having the named var with a given value? > > I am wondering if this is worth fixing it in the first place. > > Opinions?  Patches ;-)? > Maybe it is worth fixing, but on a case-by-case basis? I mean changing the execv_git_cmd interface (or create a new execv function), so that it can get the list of config vars to pass down to the callee. A trivial case of its use would be to just pass the current config (or, more likely, none). Or, one could give it its own list of config parameters.