From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 29 Jul 2010 23:07:20 GMT
Subject: Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point
Message-ID: <AANLkTi=Qf1OUmjkpL-6e8gT8MU9G=m37sxrdAoyj5=R0@mail.gmail.com>
In-Reply-To: <20100729220111.GA28176@wo.int.altlinux.org>

On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin <ldv@altlinux.org> wrote:
> Reported-by: Ivan Zakharyaschev <imz@altlinux.org>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
>
> This is just a regression test for the bug.

Thanks, always good to have more tests.

>  t/t2018-checkout-new-branch-by-regexp.sh |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
>  create mode 100755 t/t2018-checkout-new-branch-by-regexp.sh
>
> diff --git a/t/t2018-checkout-new-branch-by-regexp.sh b/t/t2018-checkout-new-branch-by-regexp.sh
> new file mode 100755
> index 0000000..78e54c5
> --- /dev/null
> +++ b/t/t2018-checkout-new-branch-by-regexp.sh
> @@ -0,0 +1,22 @@
> +#!/bin/sh
> +
> +test_description='checkout -b new_branch :/regexp'
> +
> +. ./test-lib.sh
> +
> +test_expect_success setup '
> +       echo a > a &&
> +       git add a &&
> +       test_tick &&
> +       git commit -m first &&
> +       echo b > b &&
> +       git add b &&
> +       test_tick &&
> +       git commit -m second
> +'

This should use test_commit (see t/README), but...

> +test_expect_success checkout '
> +       git checkout -b new_branch :/first
> +'
> +
> +test_done

...it looks like this can just be added to the end of
t2018-checkout-branch.sh instead of creating a new test. Creating a
new file just for a single test for such a simple feature is a bit of
an overkill.