From: Piotr Krukowiecki Date: Tue, 08 Mar 2011 19:26:43 GMT Subject: Re: [PATCH] Honor HP C's noreturn attribute Message-ID: In-Reply-To: <7v4o7dfndw.fsf@alter.siamese.dyndns.org> On Tue, Mar 8, 2011 at 8:00 PM, Junio C Hamano wrote: > Michal Rokos writes: > >> HP C for Integrity servers (Itanium) gained support for noreturn >> attribute sometime in 2006. It was released in Compiler Version A.06.10 >> and made available in July 2006. >> >> The __HP_cc define detects the HP C compiler version. Precede the >> __GNUC__ check so it works well when compiling with HP C using -Agcc >> option that enables partial support for the GNU C dialect. The -Agcc >> defines the __GNUC__ too. >> >> Signed-off-by: Michal Rokos > > We tend to prefer new code be appended at the end of if/elif/.../then/fi > cascade when there is no strong reason to do otherwise; your log message > clearly explains why this particular #if needs to come before the existing > one. > > I love it when people write a very readable log message to explain why the > patch _has_ to be the way it is.  Very good job. I liked it too, but it'd be even better to put the comment in the code IMO. I don't think anyone would check the commit to see if he can change the order of the #ifdefs ... (So please comment in code more!) -- Piotr Krukowiecki