From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 14 Aug 2010 19:08:42 GMT
Subject: Re: [PATCH] git-svn: fix fetch with deleted tag
Message-ID: <AANLkTi=FKDa4sTTd1b=9yxsWafY1jEEdPrHZ88+uPozi@mail.gmail.com>
In-Reply-To: <84607.29034.qm@web30003.mail.mud.yahoo.com>

On Sat, Aug 14, 2010 at 18:49, David D. Kilzer <ddkilzer@kilzer.net> wrote:
> On Sat, August 14, 2010 at 7:52:48 AM, Ævar Arnfjörð Bjarmason wrote:
>> On Sat, Aug 14, 2010 at 14:07, David D. Kilzer <ddkilzer@kilzer.net> wrote:
>> >  +++ b/t/t9156-git-svn-fetch-deleted-tag-2.sh
>> >  @@ -0,0 +1,45 @@
>> > +#!/bin/sh
>> > +
>> > +test_description='git  svn fetch deleted tag 2'
>>
>> Any reason not to include both of these in the  same file? Just to
>> avoid having to manually reset the  repository?
>
> It was easier to run the tests individually when working on them, and I was
> hesitant to combine the setup steps from each test since it wouldn't be as clear
> which steps were for which test in the future.

If you think it's easier to maintain like this then by all means keep
it as it is. I was just wondering why it was like this, that's all.

> I realize this may be slower when running the tests, but it makes
> them easier to maintain, especially when one hasn't looked at the
> tests in a while.

The SLOOOOW part of running the git svn tests is definitely *not* the
tiny bit of shellscript required to execute each *.sh file :)

> Is there a nice way to reset the repository between steps?

I don't know if this applies in this case but if you need fresh repos
for each tests you can usually do:

    test_expect_success 'test #1' '
        (test_create_repo one &&
        cd one &&
    	...)
    '

    test_expect_success 'test #2' '
        (test_create_repo two &&
        cd two &&
    	...)
    '

But I haven't looked at the svn_* functions you're using, so perhaps
that's not possible here.

> Thanks for the feedback!  I've already applied your other suggestions.

Cool, good to know that it was helpful.