From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 11 Aug 2010 12:15:23 GMT
Subject: Re: [PATCH 9/9] commit: suppress status summary when no changes staged
Message-ID: <AANLkTi=DPu+roNsuWZARkK=cmKhcqMx=CDyiv6cf7tof@mail.gmail.com>
In-Reply-To: <20100811073028.GA5450@burratino>

On Wed, Aug 11, 2010 at 07:30, Jonathan Nieder <jrnieder@gmail.com> wrote:

> -test_expect_success 'status' '
> +test_expect_failure 'status' '
>        (
>                cd test &&
>                git checkout b1 >/dev/null &&

Better to test_expect_success like my patch does and explicitly check
the output, otherwise that test will pass if any part of it fails,
e.g. if the checkout fails.

Not likely, but it's more likely that the output will change again, in
which case the grep tests I did would start failing again.

It's good to have test canaries like that for important parts of our
output.