From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Sun, 27 Feb 2011 10:37:39 GMT
Subject: Re: [PATCH 3/3] mergetool--lib: Add the proper executable name for ECMerge
Message-ID: <AANLkTi=CuyNLNuuootcd8_H9Zh=WqAwiS+S6PJjPAfcw@mail.gmail.com>
In-Reply-To: <4D69E628.5040007@gmail.com>

On Sun, Feb 27, 2011 at 06:50, Chris Packham <judge.packham@gmail.com> wrote:

>> +     ecmerge)
>> +             echo guimerge
>> +             ;;
>>       emerge)
>>               echo emacs
>>               ;;
>
> I think this is another case of linux/windows versions of the
> application having different executable names.
>
> chrisp@laptop:~> tar -tf Download/ecmerge-2.3.123.linux.x86.tbz
> /usr/local/bin/ecmerge
> /opt/elliecomputing/ecmerge/guimerge
> /opt/elliecomputing/ecmerge/guimerge.exe

Indeed, well except that Linux has both "ecmerge" and "guimerge",
whereas Windows only has "guimerge", which is why I went with the
latter. Giving it a second thought, my patch is a little inconvenient
for Linux users, as it will stop making ecmerge work out of the box
(without first setting mergetool.ecmerge.path), whereas Windows users
need to set mergetool.ecmerge.path anyway.

I've also contacted the makers of ECMerge and asked them to unify the
naming across platforms. Maybe we should just drop this patch until
they did.

Chris, what do you think?

-- 
Sebastian Schuberth