From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 30 Aug 2010 19:57:29 GMT
Subject: Re: [PATCH 1/6] Add string comparison functions that respect the ignore_case variable.
Message-ID: <AANLkTi=CeeBkHZgCOtACxCtWoab6Q+3Jwtx327KDFjqh@mail.gmail.com>
In-Reply-To: <201008302040.10399.j6t@kdbg.org>

On Mon, Aug 30, 2010 at 18:40, Johannes Sixt <j6t@kdbg.org> wrote:
> On Montag, 30. August 2010, Joshua Jensen wrote:
>> From: Ævar Arnfjörð Bjarmason
>> >      +       COMPAT_OBJS = compat/fnmatch/fnmatch.o
>> >      +       COMPAT_CFLAGS = -Icompat -Icompat/fnmatch
> ...
>> You added COMPAT_OBJS
>> above, but I think there is no linker guarantee it will pick up
>> compat/fnmatch/fnmatch.o over the C runtime version?
>
> The way linkers work ensures that git code picks up the compat version when
> defined this way.

So why does e.g. compat/snprintf.c need to "#undef snprintf" before
defining it again?