From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Tue, 17 Aug 2010 17:50:03 GMT
Subject: Re: [PATCH 03/24] t7600 (merge): do not launch gitk for --debug
Message-ID: <AANLkTi=1Fz_wdf-grxFB17zUXpW+d26MudbbJP5K=fO_@mail.gmail.com>
In-Reply-To: <20100817065459.GC22057@burratino>

Heya,

On Tue, Aug 17, 2010 at 01:54, Jonathan Nieder <jrnieder@gmail.com> wrote:
> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'


> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'

> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'

Really? Why can't you stuff the command to execute in a variable? On
that note, why wasn't that done in the first place?! This kind of
repetition is not very DRY.

-- 
Cheers,

Sverre Rabbelier