From: Nguyen Thai Ngoc Duy Date: Wed, 16 Mar 2011 14:20:43 GMT Subject: Re: [PATCH nd/struct-pathspec] declare 1-bit bitfields to be unsigned Message-ID: In-Reply-To: <20110316034232.GA26027@elie> 2011/3/16 Jonathan Nieder : > As "gcc -pedantic" notices, a two's complement 1-bit signed integer > cannot represent the value '1'. > >  dir.c: In function 'init_pathspec': >  dir.c:1291:4: warning: overflow in implicit constant conversion [-Woverflow] Thanks. I think I was aware of this but neglected because they are used as booleans, 1 or -1 does not matter. Good fix anyway. -- Duy