From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 01 Sep 2010 15:40:50 GMT
Subject: Re: [PATCH 1/3 v2] tests: factor HOME=$(pwd) in test-lib.sh
Message-ID: <AANLkTi=+_+62LqhnO6dee9fv=1_naGoNzsusNt9OpX_N@mail.gmail.com>
In-Reply-To: <7vaao17ahi.fsf@alter.siamese.dyndns.org>

On Wed, Sep 1, 2010 at 15:24, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Tue, Aug 31, 2010 at 07:42, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>> On Mon, Aug 30, 2010 at 23:15, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
>>>> The same pattern is used in many tests, and makes it easy for new ones to
>>>> rely on $HOME being a trashable, clean, directory.
>>>>
>>>> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>>>> ---
>>>> Just re-ordered the patch to make this one the first.
>>>>
>>>> I took Ævar's suggestion of using $TRASH_DIRECTORY instead of $(pwd).
>>>
>>> Thanks,
>>>
>>> Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>>
>> Junio: FYI you picked up v1 of this for next/pu, not this v2.
>
> I know.
>
> The originals all used $(pwd) as far as I saw, and it _is_ more faithful
> and correct refactoring not to use $TRASH_DIRECTORY in this patch, no?
> You can choose to change it to use $TRASH but that should be done in a
> separate patch.

I just wanted to note it in case you didn't see it. It's a trivial
issue and I don't really care, I just wanted to note it in case the v2
went past you.