From: Alexander Rinass Date: Mon, 14 Mar 2016 21:45:43 GMT Subject: Re: git diff does not precompose unicode file paths (OS X) Message-ID: In-Reply-To: <56DEC5DD.2070407@web.de> > On 08 Mar 2016, at 13:30, Torsten Bögershausen wrote: > >>> And if not, I can put it on my TODO-stack. >> I have read through the official contribution guidelines and I think I can >> send an official patch. >> >> In this case, would you prefer to have a single commit since the change >> is related? Or would you prefer keeping it in separate commits, since >> they are different commands and I can use commit subjects like “diff:” >> and “diff-index:”, etc.? >> > Thanks for the work. > The same issue fixed at different places: > I personally would prefer a single commit. > > Another thing is, if we want to add TC in t3910, > to avoid future regressions. > (Otherwise I can help with those) I created a test case but git diff exits with 0 if it does not recognize the file path so the test case always succeeds. Can you give me a hint or one example test case?