From: Kyle J. McKay <mackyle@gmail.com>
Date: Mon, 22 Jul 2013 12:52:49 GMT
Subject: Re: [PATCH v7 4/4] config: allow http.<url>.* any user matching
Message-ID: <A7388818-53EA-4D77-9342-B15D74495811@gmail.com>
In-Reply-To: <7va9lfqi3b.fsf@alter.siamese.dyndns.org>

On Jul 21, 2013, at 22:28, Junio C Hamano wrote:
> "Kyle J. McKay" <mackyle@gmail.com> writes:
>
>> diff --git a/test-url-normalize.c b/test-url-normalize.c
>> index d68312d..f325571 100644
>> --- a/test-url-normalize.c
>> +++ b/test-url-normalize.c
>> @@ -9,7 +9,7 @@ int main()
>
> It looks like that this program could also drive http_options()
> directly, or alternatively make a call
>
> 	git_config(http_options, &info);
>
> in its main() to let the config parser do its work, to make sure
> that the machinery picks up the right values from the desired entry
> in the configuration file, with a bit more effort.

OK.

> OK, so if there is a configuration for a generic URL that is longer,
> it defeats a shorter URL with a specific username, e.g. when talking
> to host.xz/name as kyle, with configuration for these two keys
> exist:
>
> 	scheme://kyle@host.xz/path
>        scheme://host.xz/path/name
>
> the value for the latter one is used.
>
> I am not complaining; just making sure that is what we want to give
> users, as it was not quite clear in the Documentation/config.txt
> part of the patch.

Will add example to Documentation/config.txt to make it clearer.