From: Steffen Prohaska Date: Sun, 28 Oct 2007 13:49:28 GMT Subject: Re: [PATCH 4/8] rev-parse: teach "git rev-parse --symbolic" to print the full ref name Message-ID: In-Reply-To: On Oct 27, 2007, at 11:53 PM, Daniel Barkalow wrote: > On Sat, 27 Oct 2007, Steffen Prohaska wrote: > >> "git rev-parse --symbolic" used to return the ref name as it was >> specified on the command line. This is changed to returning the >> full matched ref name, i.e. "git rev-parse --symbolic master" >> now typically returns "refs/heads/master". >> >> Note, this changes output of an established command. It might >> break existing setups. I checked that it does not break scripts >> in git.git. > > I think this makes the --create option to push unnecessary, as > interactive > users could use a suggested explicit value (or whatever they actually > meant), while scripts could replace $name with $(git rev-parse -- > symbolic > $name) as easily as they could add --create, and by more explicit > as to > what they're doing. I'll remove 4/8 (git rev-parse --symbolic) from the patch series. It is not directly related to the push behaviour and Junio pointed out that the old behavior of git rev-parse must be maintained as is. I'm not particularly interested in modifying git rev-parse. If someone else is, feel free to take over my patch. I'll keep the '--create' flag. Its intention is obvious and easy to explain to users. Much easier than "git rev-parse --dwim_ref ..." or something similar. Steffen