From: Philip Oakley <philipoakley@iee.org>
Date: Tue, 27 Jan 2015 07:26:07 GMT
Subject: Re: [PATCHv2] commit: reword --author error message
Message-ID: <A36392C1208647BC9F2CA89478DCC754@PhilipOakley>
In-Reply-To: <20150127024553.GA24569@peff.net>

From: "Jeff King" <peff@peff.net>
> On Mon, Jan 26, 2015 at 06:43:46PM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > ... I somehow had trouble making
>> > sense of Z ("a match...") as a noun.
>>
>> > I wonder if adding back in the missing verb, rather than a colon, 
>> > would
>> > also make more sense:
>> >
>> >   --author '%s' is neither 'Name <email>' nor a match for an 
>> > existing author
>>
>> Then
>>
>> >   --author '%s' is not 'Name <email>' and matches no existing 
>> > author
>>
>> would be the shortest, sweetest and hopefully grammatical, perhaps?
>
> Yes, that one make perfect sense to me.
>
Agreed.
Philip