From: David Turner <david.turner@twosigma.com>
Date: Mon, 21 Nov 2016 18:12:32 GMT
Subject: RE: [PATCH 13/16] submodule: teach unpack_trees() to update submodules
Message-ID: <9fa4c24dc02941ff8a43c4b97dad8dc0@EXMBNJE7.ad.twosigma.com>
In-Reply-To: <CAGZ79kb-TKgQm1_p3NyJS7mso2FFWMNHa7F8vwzocjSJfyjXJQ@mail.gmail.com>



> -----Original Message-----
> From: Stefan Beller [mailto:sbeller@google.com]

> >> +                             if (submodule_is_interesting(old->name,
> null_sha1)
> >> +                                 && ok_to_remove_submodule(old->name))
> >> +                                     return 0;
> >> +                     }
> >
> > Do we need a return 1 in here somewhere?  Because otherwise, we fall
> through and return 0 later.
> 
> Otherwise we would fall through and run
> 
>     if (errno == ENOENT)
>         return 0;
>     return o->gently ? -1 :
>         add_rejected_path(o, error_type, ce->name);
> 
> which produces different results than 0?

Oh, I see.  I was misreading that errno check.