From: Taylor Blau Date: Wed, 12 Jul 2023 23:38:16 GMT Subject: [PATCH 19/20] commit-graph.c: prevent overflow in `write_commit_graph()` Message-ID: <9f66e1e6eeb7386010d7387c37766260bf38b338.1689205042.git.me@ttaylorr.com> In-Reply-To: In a similar spirit as previous commits, ensure that we don't overflow when trying to read an existing OID while writing a new commit-graph. Signed-off-by: Taylor Blau --- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index c679d1d633..20d9296c8b 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -2453,7 +2453,7 @@ int write_commit_graph(struct object_directory *odb, struct commit_graph *g = ctx->r->objects->commit_graph; for (i = 0; i < g->num_commits; i++) { struct object_id oid; - oidread(&oid, g->chunk_oid_lookup + g->hash_len * i); + oidread(&oid, g->chunk_oid_lookup + st_mult(g->hash_len, i)); oid_array_append(&ctx->oids, &oid); } } -- 2.41.0.347.g7b976b8871f