From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sun, 10 Nov 2024 14:42:08 GMT
Subject: Re: [RFC PATCH v4 06/19] Makefile: extract script to massage Shell scripts
Message-ID: <9d807eeb-db00-4d17-b909-b73944cff2c6@gmail.com>
In-Reply-To: <2cf8cf86218e0cb1f3477897cb3d0be950d452ac.1729771605.git.ps@pks.im>

Hi Patrick

On 24/10/2024 13:40, Patrick Steinhardt wrote:
> 
> +	add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${shell_gen_path}
> +		COMMAND ${CMAKE_SOURCE_DIR}/generate-script.sh

Same comments as the other patch - this need ${SH_EXE} as the command name

> @@ -1156,6 +1160,10 @@ string(REPLACE "@GIT_INTEROP_MAKE_OPTS@" "" git_build_options "${git_build_optio
>   string(REPLACE "@GIT_TEST_INDEX_VERSION@" "" git_build_options "${git_build_options}")
>   string(REPLACE "@GIT_TEST_PERL_FATAL_WARNINGS@" "" git_build_options "${git_build_options}")
>   string(REPLACE "@RUNTIME_PREFIX@" "${RUNTIME_PREFIX}" git_build_options "${git_build_options}")
> +string(REPLACE "@GITWEBDIR@" "${GITWEBDIR}" git_build_options "${git_build_options}")
> +string(REPLACE "@USE_GETTEXT_SCHEME@" "" git_build_options "${git_build_options}")
> +string(REPLACE "@LOCALEDIR@" "LOCALEDIR" git_build_options "${git_build_options}")

s/"LOCALEDIR"/"${LOCALEDIR}"/

Best Wishes

Phillip