From: Victoria Dye Date: Thu, 11 Aug 2022 15:43:47 GMT Subject: Re: [PATCH v3 06/11] diagnose.c: add option to configure archive contents Message-ID: <9d1b0cb9-5c21-c101-8597-2fe166cb6abe@github.com> In-Reply-To: <220811.86ilmzqchn.gmgdl@evledraar.gmail.com> Ævar Arnfjörð Bjarmason wrote: > > On Wed, Aug 10 2022, Victoria Dye via GitGitGadget wrote: > >> index 06dca69bdac..9bb6049bf0c 100644 >> --- a/diagnose.h >> +++ b/diagnose.h >> @@ -2,7 +2,14 @@ >> #define DIAGNOSE_H >> >> #include "strbuf.h" >> +#include "parse-options.h" > > This is a stray include that isn't needed at this point, some mistake, > or needed by a subsequent patch? It's needed by patch 8 [1]. If I re-roll again, I'll move this '#include' to that patch. Thanks! [1] https://lore.kernel.org/git/3da0cb725c927d08dd9486286e06bdb76896f5b7.1660174473.git.gitgitgadget@gmail.com/