From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Tue, 08 Dec 2020 22:23:16 GMT
Subject: Re: [PATCH v2 2/5] Documentation/Makefile: conditionally include ../GIT-VERSION-FILE
Message-ID: <9cde91bf-8808-6110-b9ea-a3385225f0a2@ramsayjones.plus.com>
In-Reply-To: <CAMP44s3hCm_2=jRv-4knNWe+V5vR_+XWjHVFkVm_LNzJ+n1sDg@mail.gmail.com>



On 07/12/2020 03:21, Felipe Contreras wrote:
> On Sun, Dec 6, 2020 at 6:35 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
[snip]
>> Notice that the 'clean' target is making a nested call to the parent
>> Makefile to ensure that the GIT-VERSION-FILE is up-to-date (prior to
>> the previous patch, there would have been _two_ such invocations).
>> This is to ensure that the $(GIT_VERSION) make variable is set, once
>> that file had been included.  However, the 'clean' target does not use
>> the $(GIT_VERSION) variable, so this is wasted effort.
> 
> Yes, this is the important information: "the 'clean' target does not use
> the $(GIT_VERSION) variable". I would feature it at the start of the
> commit message.

Heh, I didn't intend to 'bury the lead' here. I spent about 30 minutes
re-writing this message to come up with an improvement; I'm not sure
that I succeeded. ;-)

v3 comming soon ...

Thanks!

ATB,
Ramsay Jones