From: Rubén Justo <rjusto@gmail.com>
Date: Wed, 05 Jun 2024 22:50:39 GMT
Subject: Re: [PATCH v4 5/6] test-terminal: introduce --no-stdin-pty
Message-ID: <9c76f1f3-f858-400e-8fc7-8e3bc9764e87@gmail.com>
In-Reply-To: <600d27c1-f9e2-4a03-af24-4de8f66526d6@gmail.com>

On Tue, Jun 04, 2024 at 11:05:15AM +0100, Phillip Wood wrote:

> Rather than adding a new flag to work around a bug in our script it might be
> better to try and fix the bug by using a loop that reads blocks of data from
> the source and writes them to the destination instead of calling copy.

To be honest, I've tried.  I haven't found a way to fix it properly.

I also thought about removing it.  I agree with Peff, removing the stdin
redirection makes more sense.  IMHO simplifies.

But, perhaps we can happily live another almost-decade with this new
--no-stdin-pty, before finally removing the stdin redirection in this
helper. :-)