From: William Baker Date: Fri, 11 Oct 2019 16:38:41 GMT Subject: Re: [PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed Message-ID: <9c012ff1-182b-d71b-cd50-9c476f26748c@gmail.com> In-Reply-To: <20191010112204.GK29845@szeder.dev> On 10/10/19 4:22 AM, SZEDER Gábor wrote: >>> +# This test covers staging/unstaging files that appear at the end of the index. >>> +# Test files with names beginning with 'z' are used under the assumption that >>> +# earlier tests do not add/leave index entries that sort below them. > > I just read through Junio's comments on the first version of this > patch, in particular his remarks about this comment. > > If this new test case below were run in a dedicated repository, then > this comment wouldn't be necessary, and all my comments below about > that not-really-initial commit would be moot, too. > Thanks for this suggestion! I will submit a v3 version of the patch with an update to the test script. - William