From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 01 Jul 2025 20:20:14 GMT
Subject: Re: [PATCH RFC v3 1/3] last-modified: new subcommand to show when files were last modified
Message-ID: <9b4742f6-9468-46a2-b612-5985d936ccff@app.fastmail.com>
In-Reply-To: <20250630-toon-new-blame-tree-v3-1-3516025dc3bc@iotcl.com>

On Mon, Jun 30, 2025, at 20:49, Toon Claes wrote:
> +	of the current working directory are included in the

in the search/traversal?

> [snip]
> +			 * a final path/sha1 state. Note that this covers some

nit: oid state?

> +			 * potentially controversial areas, including:
> +			 *
> +			 *  1. A rename or copy will be found, as it is the
> +			 *     first time the content has arrived at the given
> +			 *     path.
> +			 *
> +			 *  2. Even a non-content modification like a mode or
> +			 *     type change will trigger it.
> +			 *
> +			 * We take the inclusive approach for now, and find
> +			 * anything which impacts the path. Options to tweak
> +			 * the behavior (e.g., to "--follow" the content across
> +			 * renames) can come later.
> +			 */
> +			mark_path(p->two->path, &p->two->oid, data);
> +			break;
> [snip]