From: demerphq Date: Mon, 20 Jul 2009 08:15:28 GMT Subject: Re: [PATCH] Add git svn gc command Message-ID: <9b18b3110907200115p4c0c3b45nc6c7f31b34ceff0c@mail.gmail.com> In-Reply-To: <20090720075929.GA5591@dcvr.yhbt.net> 2009/7/20 Eric Wong : > Robert Zeh wrote: >> Add a git svn gc command that gzips all unhandled.log files, and removes >> all index files under .git/svn. >> >> Signed-off-by: Robert Allan Zeh >> --- >>  Documentation/git-svn.txt |    4 ++++ >>  git-svn.perl              |   37 +++++++++++++++++++++++++++++++++++++ >>  t/t9140-git-svn-gc.sh     |   45 ++++++++++++++++++++++++++++++++++++ >> +++++++++ >>  3 files changed, 86 insertions(+), 0 deletions(-) >>  create mode 100755 t/t9140-git-svn-gc.sh > > Hi Robert, > > Your mailer is mangling whitespace badly so the patch isn't applying > at all.  Make sure indents are real tabs like the rest of the code. > > Some more comments below, but I think this will be a good addition > to git svn. > >> --- a/git-svn.perl >> +++ b/git-svn.perl >> @@ -35,11 +35,14 @@ push @Git::SVN::Ra::ISA, 'SVN::Ra'; >>  push @SVN::Git::Editor::ISA, 'SVN::Delta::Editor'; >>  push @SVN::Git::Fetcher::ISA, 'SVN::Delta::Editor'; >>  use Carp qw/croak/; >> +use Compress::Zlib; > > I'd "require" Compress::Zlib lazilly so it's not loaded at startup. > It's not a stock component of Perl and not needed for the majority of > commands. Actually, it has been a core component since 5.9.3 cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"