From: demerphq Date: Tue, 07 Apr 2009 21:44:31 GMT Subject: Re: [PATCH RFC 6/6] send-email: Remove horrible mix of tabs and spaces Message-ID: <9b18b3110904071444g2a8c4b66l9c22bd5ffabe3d6a@mail.gmail.com> In-Reply-To: 2009/4/7 Michael Witten : > On Tue, Apr 7, 2009 at 16:35, demerphq wrote: >> 2009/4/7 Michael Witten : >>> +## WARNING! ACHTUNG! ATTENTION! ADVERTENCIA! >>> +##   Currently, this file uses tabs (like the rest of git source) to >>> +##   delineate code structure. Do NOT under any circumstances mix tabs >>> +##   and spaces across lines that share a relationship in terms of layout. >>> +##   In fact, it would currently be best to use only tabs, so please set >>> +##   your editor(s) accordingly. This code is already trashy enough. Please >>> +##   don't make it worse. >> >> Perltidy the file? >> >> Yves > > Oooh, that's sexy! > > I'll have to give that a try. However, I've been entertaining the idea > of rewriting the whole thing anyway; it's in need of much more than > reformatting. Yes. I notice evilness in there. Not necessarily dire burn your house down evilness, but evilness none the less. > As a side note, Yves, I sent the patches to perl5-porters again about > 1.6666666 hours ago, but nothing seems to have come through; I'll try > again later. You mean the 14 patches I just applied and pushed to blead? :-) cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"