From: demerphq Date: Sat, 07 Feb 2009 09:32:37 GMT Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match Message-ID: <9b18b3110902070132h2401a2f1w7abefa1c9906a567@mail.gmail.com> In-Reply-To: <200902071025.02491.jnareb@gmail.com> 2009/2/7 Jakub Narebski : > Junio C Hamano wrote: >> Jakub Narebski writes: >> >> > It would unfortunately falsely match... but we cannot eliminate this >> > case (well, at least not checking if hexnumber is followed by dot), >> > because of totally legitimate >> > >> > ... at commit 8457bb9e. >> > >> > So even with that we would have still false matches... >> >> Yeah, so what's the value in v2 over v1? It is still wrong but it is less >> wrong than it used to be? I think the word-boundary one made a good >> sense. I do not see the @lookahead adding much value at all. > > Right. So v2 is less useful that I thought it to be; and adding further > "exceptions" doesn't seem like a good idea. The 'msgid' committag > when/if it gets implemented would help there... > > So please take v1, as it is sane improvement and generic enough. If you make it configurable then everybody can be happy right? Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"