From: Derrick Stolee Date: Tue, 16 Sep 2025 02:00:45 GMT Subject: Re: [PATCH v3 5/7] sparse-checkout: add --verbose option to 'clean' Message-ID: <9b001093-0d9d-47b2-be10-333534a748e2@gmail.com> In-Reply-To: On 9/15/2025 3:12 PM, Junio C Hamano wrote: > Derrick Stolee writes: > >> On 9/12/2025 6:30 AM, Derrick Stolee via GitGitGadget wrote: >>> From: Derrick Stolee >> >>> +static void list_every_file_in_dir(const char *msg, >>> + const char *directory) >>> +{ >>> + struct strbuf path = STRBUF_INIT; >>> + >>> + strbuf_addstr(&path, directory); >>> + fprintf(stderr, "list every file in %s\n", directory); >> >> I don't know how I missed that this debugging output line snuck >> in and stayed through my testing. This line should be removed. >> >>> + for_each_file_in_dir(&path, list_file_iterator, msg); >>> + strbuf_release(&path); >>> +} > > ;-) Don't feel bad. Nobody among other people caught it either. > > Locally amended so no need to resubmit only to fix this. Thanks! -Stolee