From: Derrick Stolee Date: Wed, 04 Nov 2026 16:33:11 GMT Subject: Re: [PATCH 05/10] commit-graph: merge the two commit graph writers Message-ID: <9a97d8ca-e7c9-4e57-905b-109df92a9eae@gmail.com> In-Reply-To: <20261104-pks-commit-graph-write-refactorings-v1-5-d013d9401a59@pks.im> On 11/4/2026 10:57 AM, Patrick Steinhardt wrote: > We have two entry points for writing commit graphs: > > - `write_commit_graph()` either writes a commit graph for all commits > in the object database, or for the commits specified via its options > struct. > > - `write_commit_graph_reachable()` writes a commit graph for all > reachable commits. > > It's somewhat pointless though to have a separate entry point for > writing a commit graph for reachable commits, as this use case can be > trivially satisfied via a flag. > > Introduce that flag and drop the separate entry point in favor of > `write_commit_graph()`. This ensures we have a single entry point for > writing commit graphs, only, which will make it easier to eventually > introduce pluggable commit graphs via the object database. The previous four patches were immediately obvious to be correct. This one takes a little bit more work, but is a valuable simplification that will lead to better code reuse in the future. Thanks, -Stolee