From: Derrick Stolee Date: Mon, 05 Feb 2018 19:29:29 GMT Subject: Re: [PATCH v2 06/14] commit-graph: implement git-commit-graph --read Message-ID: <9a460925-a143-ecc0-8651-900b8e731caf@gmail.com> In-Reply-To: <20180201162324.fa8b38531955ee5378e5c5ff@google.com> On 2/1/2018 7:23 PM, Jonathan Tan wrote: > On Tue, 30 Jan 2018 16:39:35 -0500 > Derrick Stolee wrote: > >> Teach git-commit-graph to read commit graph files and summarize their contents. > One overall question - is the "read" command meant to be a command used > by the end user, or is it here just to test that some aspects of reading > works? If the former, I'm not sure how useful it is. And if the latter, > I think that it is more useful to just implementing something that reads > it, then make the 11/14 change (modifying parse_commit_gently) and > include a perf test to show that your commit graph reading is both > correct and (performance-)effective. The "read" command is intended for use with the tests to verify that the different --write commands write the correct number of commits at a time. For example, we can verify that the closure under reachability works when using --stdin-commits, that we get every commit in a pack when using --stdin-packs, and that we don't get more commits than we should. It doesn't serve much purpose on the user-facing side, but this is intended to be a plumbing command that is called by other porcelain commands.