From: Johannes Schindelin Date: Thu, 08 Oct 2015 19:10:46 GMT Subject: Re: [PATCH v3 3/4] Add a function to release all packs Message-ID: <991eaf53b382e8156ef9486014c1a4a5@dscho.org> In-Reply-To: Hi Junio, On 2015-10-07 19:49, Junio C Hamano wrote: > Johannes Schindelin writes: > >> On Windows, files that are in use cannot be removed or renamed. That >> means that we have to release pack files when we are about to, say, >> repack them. Let's introduce a convenient function to close them >> pack files. >> >> While at it, we consolidate the close windows/close fd/close index >> stanza in `free_pack_by_name()` into the `close_pack()` function that >> is used by the new `close_all_packs()` function to avoid repeated code. >> >> Signed-off-by: Johannes Schindelin >> --- > > This is the only one that was updated among the four and the change > looks sensible. I'd reword the end of the first paragraph of the > proposed log message, though, to replace "close them pack files" > with "close all the pack files and their idx files". > > Thanks. This time I was more clever and checked `pu` before sending off a fixed patch, seeing that you patched this already. Thanks, Dscho