From: Brandon Casey Date: Tue, 02 Feb 2010 15:23:41 GMT Subject: Re: [PATCH] resolve-undo.c: silence compiler complaints by casting void * to char * Message-ID: <97tOvtEqk8MiRaSVk9lJHcwIzHMJLo8v4hw8LEH-4JfIi16BeIKnLA@cipher.nrlssc.navy.mil> In-Reply-To: <7vr5p4favs.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Junio C Hamano writes: > >> Thanks for catching this. >> >> In this particular case, I however suspect that it would be cleaner to >> declare that the first parameter to resolve_undo_read() is a "char *" >> (or even "const char *"), as we are dealing with NUL delimited list of >> octal numbers and character strings. > > It would look like this. This works for me. Thanks, -brandon